Use librtcx for JIT-LTO - #2311
Open
arhag23 wants to merge 16 commits into
Open
Conversation
cjnolet
added
improvement
rapids-bot Bot
pushed a commit
to rapidsai/librtcx
that referenced
this pull request
Jul 21, 2026
Fixes the CMake logic to always link against library dependencies and properly export dependencies. Also fixes typo with install command file name and adds missing files. Testing against cuVS CI: NVIDIA/cuvs#2311 Authors: - https://github.com/arhag23 Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: #11
arhag23
changed the title
bdice
requested changes
Aug 3, 2026
| #pragma once | ||
|
|
||
| #include <cuvs/detail/jit_lto/AlgorithmPlanner.hpp> | ||
| #include <AlgorithmPlanner.hpp> |
Contributor
There was a problem hiding this comment.
We need these in some kind of subdirectory, not on the top level include path.
Contributor
Author
There was a problem hiding this comment.
If this looks okay rapidsai/librtcx#13 then we can merge that and fix the include paths in this PR.
Contributor
Author
There was a problem hiding this comment.
@bdice do the style changes in that PR look okay for you? The header will then end up under the rtcx subdirectory.
divyegala
reviewed
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes reusable JIT-LTO logic as this is now maintained in librtcx.