feat: Add Templated iPXE operating system support#2812
Draft
kfelternv wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
…ventory sync Signed-off-by: Kyle Felter <kfelter@nvidia.com>
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh port of the Templated iPXE Operating System feature onto current
mainas a clean stack (supersedes the muddled #2616). Adds an iPXE template-based OS variant (alongside Image and raw iPXE) with a per-OS scope (Local/Global/Limited) that decides which side is the source of truth, and keeps OS definitions in sync with on-site NICo Core.Architecture
Global/LimitedOS): the REST handler validates, then pushes to Core through the generic Core gRPC proxy from feat: Add generic Core gRPC proxy and BMC credential endpoints #2477 —common.ExecuteCoreGRPCper associated site, invoking the unaryforge.ForgemethodsCreateOperatingSystem/UpdateOperatingSystem/DeleteOperatingSystem, with per-siteOperatingSystemSiteAssociationstatus (Synced/Error) and an aggregate OS status. Image OS keeps its existing OsImage workflow path unchanged. No bespoke per-resource site-workflow or site-agent push is added.Local-scope OS + iPXE templates, which carbide-rest is not the source of truth for): site-agent collectors publish inventory that cloud inventory workflows reconcile into the DB.What's implemented
operating_systemscope + iPXE template columns,ipxe_template+ipxe_template_site_associationtables,operating_system_site_association.controller_state, additive migration with a real down migration, proto conversions.OperatingSystemInventory+IpxeTemplateInventoryininventory.proto(regenerated; onlyinventory.pb.gochanged).UpdateOperatingSystemsInDB) + OS/iPXE-template inventory workflows.authTokenredaction in responses; route registration;instance/instancebatchwiring for the Templated iPXE OS type.spec.yamlupdated (new OS fields,IpxeTemplate/param/artifact schemas, 2 endpoints) and the Go SDK regenerated for the new endpoints/fields.Verification
go build ./...(whole module) — PASSdb/pkg/db/model,workflow(activity + workflow),api+api/pkg/api/model+api/pkg/api/handler,site-workflow(activity + workflow), andsite-agent(make test-site-agent, mock core/flow).gofmt/go vetclean;sdk/standardbuilds.Notes for review
main's TenantAdmin/tenant-ownership model for the OS handler (did not port the old branch's provider/tenant ownership overhaul);Globalscope resolves to the tenant's Registered sites.operatingsystemsite-agent manager rather than a separate iPXE-template manager — functionally equivalent, lower-risk.authTokens are nested insideipxe_template_artifacts[]; the proxy redacts only top-level fields, so they reach Core as-is (and are redacted in API responses). Nested-secret redaction would require a proxy extension.main's committed SDK is slightly stale vs a cleanmake generate-sdk; this PR includes only the feature-relevant SDK files and preserves the hand-maintainedclient.goio.Readerdecode branch rather than dropping it.Optional follow-ups
authTokenredaction).Type of Change
Services Affected
Breaking Changes
None expected — additive.