Skip to content

feat(release): register nvcf-ui as a releasable subproject - #714

Merged
kristinapathak merged 1 commit into
mainfrom
feat/nvcf-ui-release-entry
Aug 6, 2026
Merged

feat(release): register nvcf-ui as a releasable subproject#714
kristinapathak merged 1 commit into
mainfrom
feat/nvcf-ui-release-entry

Conversation

@balajinvda

@balajinvda balajinvda commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Why

nvcf-ui has a Bazel matrix row but no entry in
tools/ci/github-release-subprojects.json, so github-release auto never
considers it and no src/uis/nvcf-ui/v* tag is ever cut. Without a tag the
release lane in nvcf-internal !122 can never fire.

What changed

One entry, 5 lines. default_tag_format then yields src/uis/nvcf-ui/v, which
is exactly the tag_prefix nvcf-internal !122 was written against.

Worth knowing: this file's generated_by header is stale.
tools/generate-subproject-ci and tools/ci/subproject-validations.yaml are no
longer in the repo, so it is hand-maintained. I checked before assuming a regen
was needed.

Testing

python3 tools/ci/test-github-release.py — 20/20 pass. Loaded github-release
directly and confirmed the new entry resolves:

tag_format    src/uis/nvcf-ui/v${version}
tag_prefix    src/uis/nvcf-ui/v
tag for 0.1.0 src/uis/nvcf-ui/v0.1.0

Not exercised: an actual release run, which needs src/uis/nvcf-ui on main.

Notes

Merge after #662 — the path does not exist on main until the UI import lands.
Pairs with nvcf-internal !122, which consumes the tag.

Summary by CodeRabbit

  • Chores
    • Added the nvcf-ui service to automated GitHub release configuration.
    • Releases for the service can now be associated with its repository and release service name.

nvcf-ui has a Bazel matrix row but no release entry, so `github-release
auto` never considers it and no src/uis/nvcf-ui/v* tag is ever cut. The
release lane waiting for that tag in nvcf-internal would sit idle forever.

Registering it yields tag prefix src/uis/nvcf-ui/v from default_tag_format,
which is what the nvcf-internal config expects.

Note the generated_by header on this file is stale: tools/generate-subproject-ci
and tools/ci/subproject-validations.yaml no longer exist in this repo, so the
file is maintained by hand.

Co-authored-by: Balaji Ganesan <bganesan@nvidia.com>
@balajinvda
balajinvda requested a review from a team as a code owner August 6, 2026 20:34
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1afe12bd-7eab-433c-a518-171bba18c2bc

📥 Commits

Reviewing files that changed from the base of the PR and between 6bb0cde and bb662a4.

📒 Files selected for processing (1)
  • tools/ci/github-release-subprojects.json

📝 Walkthrough

Walkthrough

The GitHub release configuration now includes the nvcf-ui service at src/uis/nvcf-ui.

Changes

GitHub release subproject registration

Layer / File(s) Summary
Register nvcf-ui release target
tools/ci/github-release-subprojects.json
Adds the nvcf-ui path and release service name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: kristinapathak

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title format is valid, but feat misclassifies a tools/ci-only release configuration change; ci is the accurate type. Use ci(release): register nvcf-ui as a releasable subproject.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/nvcf-ui-release-entry

Comment @coderabbitai help to get the list of available commands.

@kristinapathak
kristinapathak merged commit cc1b487 into main Aug 6, 2026
1 check passed
@kristinapathak
kristinapathak deleted the feat/nvcf-ui-release-entry branch August 6, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants