Use the TrackedValue API from RFC 1071's overloaded tracked() - #3
Merged
NullVoxPopuli merged 1 commit intoJul 23, 2026
Conversation
tracked(value) in ember-source 7.3.0-alpha.5 returns a TrackedValue whose API is .value/.get()/.set()/.update(). The benchmark code was using the RFC's earlier cell names (.current/.read()), which fail silently in the prod build: row labels render empty, selection never shows, and benchmarks 03_update10th1k and 04_select1k fail the harness plausibility check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
NullVoxPopuli
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
nvp/update-ember(the branch behind krausest#2061).tracked(value)in ember-source 7.3.0-alpha.5 returns aTrackedValuewhose API is.value/.get()/.set()/.update()(emberjs/ember.js#21471). The benchmark code was using the RFC's earlier cell names —.currentin the template and.read()inupdateData— which fail silently in the prod build: row labels render empty, selection never shows, and03_update10th1k_x16/04_select1kfail the harness plausibility check withlabel.read is not a functionin the console.With this fix the full suite passes the plausibility check locally; before/after numbers are in this comment on the upstream PR.
🤖 Generated with Claude Code