[IMP] server_environment: module uninstallation#261
Conversation
gurneyalex
force-pushed
the
18.0-server_environment_uninstall_helper
branch
from
0ecea77 to
398d5b1
Compare
|
Hello @gurneyalex. Thank you for your work! I did some tests on my side. I suggested a fixup, since I was not falling into the fallback logic because no processed field was required. I believe that is because we set all fields as not required in the |
gurneyalex
force-pushed
the
18.0-server_environment_uninstall_helper
branch
4 times, most recently
from
5d7e4ed to
f5d0e5c
Compare
twalter-c2c
left a comment
twalter-c2c
left a comment
There was a problem hiding this comment.
Thank you @gurneyalex! Minor remark regarding the USAGE.md.
gurneyalex
force-pushed
the
18.0-server_environment_uninstall_helper
branch
2 times, most recently
from
8f16e59 to
5fa1624
Compare
Add a helper to manage the restoring of the database columns when a module using `server_environment` is uninstalled or the dependency on `server_environment` is dropped. Document how to use the helper in an uninstall script or in an upgrade script (if a new version of the addon drops the dependency).
gurneyalex
force-pushed
the
18.0-server_environment_uninstall_helper
branch
from
5fa1624 to
c7c194d
Compare
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8868ad5. Thanks a lot for contributing to OCA. ❤️ |
5 participants
Add a helper to manage the restoring of the database columns when a module using
server_environmentis uninstalled or the dependency onserver_environmentis dropped.Document how to use the helper in an uninstall script or in an upgrade script (if a new version of the addon drops the dependency).