feat: force ipv6 via api6 call rather than api64 - #190
Open
418error wants to merge 1 commit into
Open
Conversation
We've been investigating some issues around IPV6 users seeing "flip flop" behaviour with the cli intermittently returning an IPV4 address via the api64 endpoint, where it should be only returning an ipv6 for that user, from what we can see this is potentially an intermittent issue with the api64 api so are forcing all users to hit the api6 endpoint, for ipv6 users with will be valid and for ipv4 it will through an nxdomain error which we will treat as "the user has no ipv6" Other changes - rename of GetMyIPs2() to GetMyIPs() - removal of the checkGotIP() function in favour of using the standard library netip package for validation of ipv4 and ipv6 addresses, with optional CIDR suffixes. - consistent ip validation across derived and defaulted in the config
418error
marked this pull request as draft
July 22, 2026 10:07
418error
marked this pull request as ready for review
July 23, 2026 12:55
MebinAbraham
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We've been investigating some issues around IPV6 users seeing "flip flop" behaviour
with the cli intermittently returning an IPV4 address via the api64 endpoint, where
it should be only returning an ipv6 for that user, from what we can see this is
potentially an intermittent issue with the api64 api so are forcing all users to
hit the api6 endpoint, for ipv6 users with will be valid and for ipv4 it will
through an nxdomain error which we will treat as "the user has no ipv6"
Other changes:
netip package for validation of ipv4 and ipv6 addresses, with optional CIDR suffixes.
How to review
Describe the steps required to test the changes.
Who can review
Describe who worked on the changes, so that other people can review.