Repository navigation
Conversation
Map locally present overlap aquifer cells so an internal aquifer face is not reported as reservoir influx. Assign the reservoir connection only to the process owning the first aquifer cell, avoiding an assertion on processes that own only later cells.
This was referenced Nov 3, 2026
GitPaean
added
the
manual:bugfix
GitPaean
force-pushed
the
numerical-aquifers-across-ranks
branch
from
November 3, 2026 16:54
e786db9 to
f920eb3
Compare
Rerun 3D_1AQU_3CELLS with its aquifer cells on two ranks. Without the split handling the run stops at an assertion.
Member
Author
|
jenkins build this opm-tests=1711 please |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A numerical aquifer whose cells are split across MPI ranks stops the run. A rank that owns aquifer cells but not the first one cannot locate the connecting cell and hits the assertion in
AquiferNumerical::checkConnectsToReservoir(); OPM keeps assertions in release builds unlessWITH_NDEBUGis set. With assertions disabled, the rank owning the first aquifer cell would also count flow to the next aquifer cell as reservoir influx when that cell is in its overlap.AquiferNumericalnow also maps the aquifer cells a process holds as overlap, so faces between aquifer cells are recognised on every rank, and only the process owning the first aquifer cell handles the reservoir connection. ThecompressedIndexdocumentation now says it covers overlap cells, which this relies on.Serial runs, and parallel runs where each aquifer stays on one rank, are unaffected.
A second serial-versus-two-rank comparison of the existing
aquifer-num/3D_1AQU_3CELLSuses the partition from OPM/opm-tests#1711, which puts the first aquifer cell on one rank and the other two on the other. On master the two-rank run stops at the assertion.