Skip to content

Improve the cmake check for using c23 support - #4924

Open
weiznich wants to merge 1 commit into
OSGeo:masterfrom
GiGainfosystems:guard_against_old_cmake_for_clang_cl
Open

weiznich wants to merge 1 commit into
OSGeo:masterfrom
GiGainfosystems:guard_against_old_cmake_for_clang_cl

Conversation

@weiznich

Copy link
Copy Markdown

This change improves the check for using c23 support from the underlying C compiler to also work with clang-cl and older cmake versions. It turns out that this is only supported for clang-cl starting with cmake version 4.1. See https://gitlab.kitware.com/cmake/cmake/-/work_items/27038 for the relevant cmake report.

  • AI (Copilot or something similar) supported my development of this PR. See our policy about AI tool use. Use of AI tools must be indicated.
  • Closes #xxxx
  • Tests added
  • Added clear title that can be used to generate release notes
  • Fully documented, including updating docs/source/*.rst for new API

I used an LLM to track down the issue, the change itself was written by myself and also verified by me

This change improves the check for using c23 support from the underlying
C compiler to also work with clang-cl and older cmake versions. It turns
out that this is only supported for clang-cl starting with cmake version
4.1. See https://gitlab.kitware.com/cmake/cmake/-/work_items/27038 for
the relevant cmake report.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant