Skip to content

Support latest changes for tx filtering hashing scheme#194

Merged
joshuacolvin0 merged 3 commits into
masterfrom
script-that-generates-censored-hashed-addresses-file
Jun 9, 2026
Merged

Support latest changes for tx filtering hashing scheme#194
joshuacolvin0 merged 3 commits into
masterfrom
script-that-generates-censored-hashed-addresses-file

Conversation

@MishkaRogachev

@MishkaRogachev MishkaRogachev commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of NIT-4912

@MishkaRogachev MishkaRogachev force-pushed the script-that-generates-censored-hashed-addresses-file branch from 61b6a33 to 928b79a Compare June 2, 2026 10:04
@MishkaRogachev MishkaRogachev reopened this Jun 2, 2026
@diegoximenes diegoximenes changed the base branch from release to master June 2, 2026 15:28
diegoximenes
diegoximenes reviewed Jun 2, 2026
View reviewed changes

@diegoximenes diegoximenes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed base branch to master.
Those changes weren't already introduced to master by recent PRs?

@MishkaRogachev MishkaRogachev changed the base branch from master to release June 3, 2026 13:41
Copilot AI changed the title Support latest changes for tx filtering hashing scheme Fix failing CI: pin prysm_validator image to v6.1.1 Jun 3, 2026
@MishkaRogachev

MishkaRogachev commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Well, I pushed "Fix with Copilot" green button and it messed up the whole PR. @diegoximenes build was failing due to prysm version. I'm not sure if I should touch it in this PR. To make the CI pass I hardcoded prysm/validator:v6.1.1

@MishkaRogachev MishkaRogachev changed the title Fix failing CI: pin prysm_validator image to v6.1.1 Support latest changes for tx filtering hashing scheme Jun 3, 2026
diegoximenes
diegoximenes requested changes Jun 5, 2026
View reviewed changes

@diegoximenes diegoximenes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not convinced this PR should exist the way it is.

Most of those changes are already on master branch.
This PR is targeting release branch.
The release and master branch are out of sync, but this is another issue.

Besides that, initTxFilteringMinioCommand is using sha256-rawbytesinput, while computeAddressHash is based on sha256-stringinput.
It is fine to create a PR to change nitro-testnode to use sha256-rawbytesinput, but it needs to target master branch.

@MishkaRogachev

MishkaRogachev commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

I am still not convinced this PR should exist the way it is.

I agree; the changes will be minimal if the release/master issue is resolved

@MishkaRogachev MishkaRogachev force-pushed the script-that-generates-censored-hashed-addresses-file branch from cb67aef to 62f6cae Compare June 8, 2026 11:59
@MishkaRogachev MishkaRogachev changed the base branch from release to master June 8, 2026 13:03
diegoximenes
diegoximenes requested changes Jun 8, 2026
View reviewed changes
Comment thread scripts/config.ts Outdated
@joshuacolvin0 joshuacolvin0 enabled auto-merge June 9, 2026 15:59
@joshuacolvin0 joshuacolvin0 merged commit 14c703d into master Jun 9, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegoximenes diegoximenes diegoximenes approved these changes

Assignees

@joshuacolvin0 joshuacolvin0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MishkaRogachev @diegoximenes @joshuacolvin0