Repository navigation
add IP data point State() regression tests - #182
Merged
Merged
Conversation
State() on an IP data point (OT_IPDP) without value type guessed the value type from the text, so texts containing a "<" or starting with a type prefix character (e.g. "test") were rejected and others were converted before sending (e.g. "1,5" was sent as "1.500000"), see OpenCCU/OpenCCU#3048. A delayed State(text, ms) always failed. The tests point an IP data point to a local TCP server and check that State() returns true and that the texts, also of a delayed State(), are received unchanged. Requires a ReGaHss including OpenCCU/ReGaHss#4.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression tests for OpenCCU/OpenCCU#3048, fixed by OpenCCU/ReGaHss#4.
Background
State()on an IP data point (OT_IPDP) without value type guessed the value type from the text:<or starting with a type prefix character (e.g.test,nachricht) were rejected (false, nothing sent),1,5was sent as1.500000,12:00as12:00:00,Wert 2025-03-06as1970-01-01),State(text, ms)always failed.With OpenCCU/ReGaHss#4 the text is sent unchanged.
Tests (
test/13-fixed-bugs.js,IP data point State() tests)OT_IPDPpointing to it,State()withx<y,<empty>,test,nachricht,dim 50%,1,5,12:00andWert 2025-03-06returnstrue, and exactly these texts are received,State("delayed <x>", 300)returnstrueand the text is received unchanged,The tests are inserted before the
UserSharedObjects() tests, so they don't conflict with #181.Local verification
Run natively with
REGA_BIN(x86_64,npx mocha test/13-fixed-bugs.js,npx xoclean):mainincluding Bump hm-simulator from 0.0.4 to 0.1.1 #4: 50 passingState()tests fail (State("x<y")and the delayedState()returnfalse).Note
The CI of this repository tests the ReGaHss binary of OpenCCU-Base. These tests fail until a ReGaHss release including OpenCCU/ReGaHss#4 is in OpenCCU-Base.