Enhance test coverage for config and dependency tree features - #7
Conversation
Cover byte-unit formats, configuration validation, and persisted configuration mutations through the public config API. Assisted-by: GitHub Copilot:GPT-5.3 Codex
Exercise Cargo metadata discovery and dependency tree formatting, including filtering, deduplication, and inverted traversal. Assisted-by: GitHub Copilot:GPT-5.3 Codex
Make dependency tree tests distinguish filtering, deduplication, and inverted traversal behavior. Verify persisted config field values and duplicate crate and symbol errors. Assisted-by: GitHub Copilot:GPT-5.3 Codex
There was a problem hiding this comment.
Pull request overview
This PR increases automated test coverage around CratePlace’s configuration handling and dependency-tree formatting/behavior, helping catch regressions in parsing/validation and DepTree display options.
Changes:
- Added unit tests for
DepTreebehaviors: dependency discovery, selection/removal by name, formatting options (dedupe/unspecified), inversion, and formatting error handling. - Added unit tests for
ConfigcoveringByteUnitformatting/serde behavior, configuration validation failures, and on-disk persistence for config mutation helpers (add_*/remove_*/set_ram).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/deps.rs | Adds a comprehensive DepTree test module covering metadata-driven discovery and display behaviors/options. |
| src/config.rs | Adds tests for ByteUnit formatting/serde, config validation edge cases, and persistence of config mutation operations via temporary files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
felipebalbi
left a comment
felipebalbi
left a comment
There was a problem hiding this comment.
Really, some proptest would be great here. Looks good though.
I have not used |
Total coverage: 51.73%