feat(strm): add file size filtering for STRM generation - #2911
Open
kanoshiou wants to merge 1 commit into
Open
Conversation
- add ParseSize helper function in pkg/utils to parse human-readable byte sizes - add minFileSize setting field to STRM driver Addition struct - filter out files below minFileSize threshold during STRM generation
Closed
25 tasks
PIKACHUIM
requested changes
Aug 10, 2026
| } | ||
|
|
||
| // ParseSize parses human-readable file size strings like "100MB", "10KB", "10G", "1.5GB", "500B", "500" into bytes. | ||
| func ParseSize(s string) (int64, error) { |
Member
There was a problem hiding this comment.
感谢您的贡献,但不是很建议搞这个自动转换文件大小单位的模块
Member
There was a problem hiding this comment.
可参考其他驱动,比如默认M,或者有个下拉菜单可以选择单位
如果这个自动转换单位有别的模块能用倒还好,如果只有这个strm过滤使用,感觉必要性不大
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Testing / 测试
go test ./...Add file size filtering logic to STRM storage and verify that non-compliant files do not trigger STRM file generation.
在 STRM 存储中新增文件大小过滤逻辑,并确认非合规文件不会触发 STRM 文件生成。
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。