Issue594 - #1224
Merged
Merged
Issue594#1224
Conversation
Fixed a bug where an extra constraint was added to solved 2dof
…ross phases and the fact that dymos reserves time for the independent variable
cmbenne3
marked this pull request as ready for review
August 6, 2026 22:20
… for time objective to allow better convergence
| ) | ||
|
|
||
| phase.set_state_options( | ||
| # self.add_state(name='time_state', target='time, rate_source='dt_dv') |
Member
There was a problem hiding this comment.
a few commented-out lines to clean up
Kenneth-T-Moore
approved these changes
Aug 17, 2026
Member
|
Looks like there is a legit failing test in Windows. |
jkirk5
enabled auto-merge
August 17, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the solved_2dof example to get it to converge with 2 new solved_2dof default phase infos added to the repo (one for takeoff and one for landing).
Adds a new benchmark test for solved_2dof for takeoff and landing.
It fixes a bug Ken spotted which unintentionally added a mass residual constraint to problems where we don't want to burn the entire fuel load during the 'mission'.
It updates the addition of state variables for the solved2dof groundroll phase now using self.add_phase() method. This allows the user to specify bounds and refs in phase_info, and removes the previously hardcoded ones (which caused issue 594).
Updates the detailed takeoff and landing solved_2dof documentation.
Related Issues
Backwards incompatibilities
None
AI Usage
Disclose any AI usage in this PR, including models used and files affected.