Conversation
Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
|
Hi @sk4zuzu 👋 Can |
|
Also, not related to these changes, but related to the role in question. Looks like Can this behavior be changed so it becomes optional, or has a default value, or an assertion, to avoid an exception. I'd say it should be optional, as it was before #173. The documentation of the parameter looks like copy pasted from DNS. Should be updated accordingly. |
|
Maybe a review of these previous changes is needed, the dpdk socket path, could be made transparent now, for example. And the queues of that nic is set to static 2, could be tied to vcpu count instead. |
|
@dann1 Yes, definitely, previous changes where more about how to combine OVS with FE VMs, so some things may be not optimal. Actually I'm working on bigger refactor of the whole role (from the templates to structures) and ability to run those FE VMs on isolated cpu and hugepages as a requirement. I think let's postpone this PR a bit. 🤗 |
dann1
left a comment
There was a problem hiding this comment.
If the nitpick about hardcoding the shares cap is deemed unnecessary, then LGTM
No description provided.