Conversation
sk4zuzu
commented
Jul 9, 2026
sk4zuzu
commented
Collaborator
- Use structures instead of templates for Libvirt XML
- Introduce 'infra_xml_variant' to increase readability of XML
- Add ipv4_mac, explode_ranges, implode_ranges filters
- Add helper/numa role to query NUMA / CPU / MEM resources
- Introduce 'infra.slice' (partition)
- Pre-calculate and apply CPU / MEM limits on the infra and machine slices
- Make context DNS-related parameters optional
- Provide default value for dpdk_socket_path
sk4zuzu
marked this pull request as draft
July 9, 2026 19:51
- Use structures instead of templates for Libvirt XML - Introduce 'infra_xml_variant' to increase readability of XML - Add ipv4_mac, explode_ranges, implode_ranges filters - Add helper/numa role to query NUMA / CPU / MEM resources - Introduce 'infra.slice' (partition) - Pre-calculate and apply CPU / MEM limits on the infra and machine slices - Make context DNS-related parameters optional - Provide default value for dpdk_socket_path Signed-off-by: Michal Opala <sk4zuzu@gmail.com>
balazsbme
removed their request for review
July 14, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.