feat: Add World#hasWorldClock check - #14086
Open
feeeedox wants to merge 2 commits into
Open
Conversation
Warriorrrr
approved these changes
Jul 26, 2026
Contributor
|
Might be better to wait for #14007 (comment). In this case this could just be a method on a new DimensionType object: (Nullable) WorldClock defaultClock() |
Member
|
There's not really any PR for that in sight yet though, this single method seems simple enough to have until then |
papermc-projects
Bot
moved this from Awaiting review
to Delayed approval
in Paper PR Queue
NonSwag
reviewed
Aug 2, 2026
NonSwag
reviewed
Aug 2, 2026
NonSwag
left a comment
NonSwag
left a comment
Contributor
There was a problem hiding this comment.
In general I agree that such a getter is needed, especially since changing the time on a world without a clock throws now.
However, is it reasonable to add this method before a proper clock API is introduced just to supersede this method?
Member
|
I will look into updating my old branch and creating a PR over the coming days |
kennytv
added
the
status: blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I couldn’t find a direct way to check whether a world has a World Clock, I quickly added this method.
This is my first PR on Paper, I hope everything’s okay :)