Repository navigation
Error when calling _search_1d_array with a multidimensional array - #2956
Merged
erikvansebille merged 3 commits intoOct 9, 2026
Merged
erikvansebille merged 3 commits into
erikvansebille merged 3 commits into
Conversation
wyatt-fluidnumerics
approved these changes
Oct 9, 2026
wyatt-fluidnumerics
left a comment
wyatt-fluidnumerics
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
erikvansebille
enabled auto-merge (squash)
October 9, 2026 13:07
erikvansebille
disabled auto-merge
October 9, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
ValueErrorwhen the_search_1d_array()function is called with a multidimensional array, therefore guarding against unexpected results like described in #2954Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None