Repository navigation
Conversation
The line lost its condition while parsing, so it granted nothing. Read it as a red and a green socket on the main hand weapon, as the Staff Mastery line does for its sockets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Two Hand Mastery line
30% increased Armour and Evasion Rating if your Main Hand Weapon has a Red and Green Socketwas not parsed. The tree showed it as "Not supported in PoB yet" and it added nothing to the character. This line replaced the two per-socket lines of this mastery in the 3.29.0 patch notes.It is now read as a red and a green socket on the main hand weapon, in the same way as the Staff Mastery line from #10067.
Steps taken to verify a working solution:
Total Increasedbreakdown in the Calcs tab now lists the mastery with both socket conditions, 30 on top of Sentinel's 24.Before screenshot:
After screenshot: