Fix a potential anomaly when some selected units are dead or not in player's control in CycleSelectionCommand - #2426
Merged
Coronia merged 10 commits intoOct 3, 2026
Conversation
… what these terminologies mean
…Phobos into feature/cmd-cycle-sel
…when some selected units are dead or not in player's control
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Skip Changelog).Skip Changelog,Skip Docs).Skip Docs).Skip Changelog,Skip Docs,Skip Credits).Description
Fixes an anomaly in the
Cycle SelectionandCycle Type Selectionhotkeys when part of theselection the cycle was started with has become unusable while the cycle is still running - the
objects died, went into limbo, or were taken over by another house (mind control).
Since this change is hard to notice in actual combat, there is no need to mention it in the documentation.