Skip to content

Fix a potential anomaly when some selected units are dead or not in player's control in CycleSelectionCommand - #2426

Merged
Coronia merged 10 commits into
Phobos-developers:developfrom
FrozenFog:feature/cmd-cycle-sel
Oct 3, 2026
Merged

Coronia merged 10 commits into
Phobos-developers:developfrom
FrozenFog:feature/cmd-cycle-sel

Conversation

@FrozenFog

@FrozenFog FrozenFog commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Since the author is me, please apply Skip Credits label.

Description

Fixes an anomaly in the Cycle Selection and Cycle Type Selection hotkeys when part of the
selection the cycle was started with has become unusable while the cycle is still running - the
objects died, went into limbo, or were taken over by another house (mind control).

Since this change is hard to notice in actual combat, there is no need to mention it in the documentation.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@DeathFishAtEase DeathFishAtEase added ❓Phobos bug Something isn't working properly ⚙️T1 T1 maintainer review is sufficient Skip Changelog PR does not need a changelog entry in docs/Whats-New.md Skip Docs PR does not need a documentation entry Needs testing labels Oct 2, 2026
Comment thread docs/Whats-New.md Outdated
@Coronia
Coronia merged commit ab5c7b8 into Phobos-developers:develop Oct 3, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❓Phobos bug Something isn't working properly Skip Changelog PR does not need a changelog entry in docs/Whats-New.md Skip Docs PR does not need a documentation entry ⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants