Skip to content

[Vanilla Enhancement] More convenient vanilla action script target specification - #2435

Merged
Coronia merged 4 commits into
Phobos-developers:developfrom
NetsuNegi:originn/feature/simplify_script_arguments
Oct 5, 2026
Merged

Coronia merged 4 commits into
Phobos-developers:developfrom
NetsuNegi:originn/feature/simplify_script_arguments

Conversation

@NetsuNegi

@NetsuNegi NetsuNegi commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

  • Now you can use more convenient argument format in vanilla action script target specification, no need to write building type index and calc scan mode offset.
    • Scan mode has low(lowest threat), high(highest threat), far(farest), near(nearest) and default to near.
  • This is suitable for 46, 47, 56, 58 action script.

In aimd.ini:

[SOMESCRIPTTYPE]  ; ScriptType
x=i,n,m           ; n - target building type name, m - scan mode

@NetsuNegi NetsuNegi added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Oct 3, 2026
@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/797/1

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Coronia Coronia added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Oct 3, 2026
@FS-21

FS-21 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Is like #1901 but with a different approach modifying the original actions instead of keeping the originals unchanged?

@Coronia

Coronia commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Is like #1901 but with a different approach modifying the original actions instead of keeping the originals unchanged?

I would say modify original script is a better approach as long as it doesn't break existing behavior. You can do the same to some of the script in #1901

@Coronia
Coronia merged commit 12672bb into Phobos-developers:develop Oct 5, 2026
7 checks passed
@FS-21

FS-21 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Then I'll update #1901 as soon as I have free time.

@NetsuNegi
NetsuNegi deleted the originn/feature/simplify_script_arguments branch October 5, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants