gdscript highlighting and packaging #3024
Conversation
|
To test this:
Then serve the book and look at Listing 5.1.3 to see the godot highlighting. Activities 5.2.1, 5.2.2, and 5.2.3 are examples how the ActiveCode will look, but it won't work fully until rs - PR 1233 has been accepted. This is a circular dependency, but this PR is the first step. |
1. gdscript-prism.js does gdscript 2.0 highlighting for code in programs 2. pretext-html.xsl and pretext-runestone.xsl were modified for the highlighting 3. gdscript_pck function in pretext.py uses extract-gdscript.xsl, and godot_helper.py to build godot packs in zip format as generated files.
1 noninteractive example in the programs section 3 activecode examples in the activecode section, and 2 noninteractive programs in one of the activities as part of an activecode example.
5fa487b to
0413007
Compare
|
@rbeezer I worked with @ascholerChemeketa to make sure that things were working properly without the pretext cli, and I made some additional changes based on reviews by @oscarlevin I think it's ready for you to review. |
|
This is the resubmission of #2892 (closed in favor of this PR, and described here as cleaned up). Before a detailed pass, the PR needs to meet conventions that were already stated explicitly in the #2892 review. A number of them recur unchanged, and several new ones appear. The consistent issue is code that does not follow PreTeXt's established conventions. Raised on #2892, still present here
New convention problems in this submission
Correctness and substance
For the next round: bring the Python and XSL into line with the conventions already given on #2892 (four-space indentation, Claude Opus 4.8, acting as a review assistant for Rob Beezer |
A new prism format was added for gdscript 2.0
A new component was added to generate gdscript packs as zip files The documentation was updated to describe the new gdscript highlighting and active code capabilities 1 program example and 3 activecode examples were added to the Runestone Testing section of the sample book.