Prevent claim retries from duplicating intent - #922
Merged
greatest0fallt1me merged 4 commits intoAug 30, 2026
Merged
Conversation
added 2 commits
August 28, 2026 10:10
- Implement DisputeEvidencePreview component for displaying evidence links with safety checks. - Introduce normalization functions for dispute evidence to handle various input formats and ensure valid URLs. - Update DisputesPage to utilize the new DisputeEvidencePreview component. - Add tests for evidence normalization to validate functionality and edge cases.
…action submissions during claim retries
|
@renoschubert is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Johnsource-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thanks for the implementation. Before this can be merged, please add a valid issue-closing reference in the PR description, such as |
Contributor
Author
|
done |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #894
Summary:
localStoragewith a 24h TTL to allow retries to reuse signed XDR or detected submission hashes.useTransactionto ensure deterministic behavior across retries and partial failures.Files changed:
lib/transaction/intent.ts- intent store (get/upsert/remove, computeXdrHash)hooks/useTransaction.hook.ts- integrate intent deduplication and lockinglib/transaction/__tests__/intent.test.ts- intent store testshooks/__tests__/useTransaction.test.tsx- focused transaction flow testsBehavior and invariants:
walletAddress:sha256(builtXdr)ensures same wallet + same built XDR map to same intent.submissionHash, retry polls for confirmation instead of re-submitting.signedXdrbut not submitted, retry will re-submit storedsignedXdr(avoids re-signing in many cases).Security considerations:
localStorage. If this is unacceptable, switch to storing only thexdrHashand require re-signing on retry.Testing:
pnpm test.Migration / compatibility:
useTransaction.executeTransaction(buildXdr)unchanged.Observability:
predictify:intents:v1for debugging.Next steps (optional):
submittedandsuccess.