ci: let wallet APK releases build mobile, cold, or both - #611
Merged
Conversation
Pre-install nightly Rust so parallel cargokit tasks stop racing rustup, which was failing the mobile APK job. Co-authored-by: Cursor <cursoragent@cursor.com>
n13
approved these changes
Aug 16, 2026
n13
left a comment
Collaborator
There was a problem hiding this comment.
APPROVE — no blocking findings.
The reusable build preserves the caller commit, validates the app choice, produces distinct mobile/cold artifacts and tag namespaces, and installs the nightly Android toolchain before Gradle can start parallel cargokit tasks. Each release job depends only on its matching build, so a failure in one app does not prevent the other app's release path. The signing-file locations also match both Android projects.
Validation:
actionlint .github/workflows/build_wallet_apk.yml .github/workflows/create_wallet_android_build.yml— passed- YAML parse of both changed workflows — passed
git diff --check d9e0d39f8b50a221f87245683c3b6008197dc326...1b39de5efacf10e17d5b5829ae6e765ad600b72c— passed- Repository
Analyzecheck — passed at the reviewed head
An actual manual APK workflow run remains pending because the new workflow_dispatch definition is not on the default branch until merge; static inspection found no blocking issue in that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@@ -0,0 +1,13 @@
Summary
wallet-v…/cold-wallet-v…)..github/workflows/build_wallet_apk.ymlso a cold-wallet failure does not block a mobile release (and vice versa).rust-src+ Android targets) beforeflutter build apkso two Gradle cargokit tasks stop racingrustup toolchain install nightly.Test plan
apps=mobile,build_mode=release,create_release=false— signed APK artifactquantus_wallet-android-releaseuploads; no GitHub Releaseapps=cold,build_mode=release,create_release=false— signed APK artifactquantus_cold_wallet-android-releaseuploadsapps=both,build_mode=debug— both debug APKs upload; no signing/release jobsapps=mobile(or both) withcreate_release=true— public release taggedwallet-v{mobile-app pubspec version}with the APK attachedrustup toolchain install nightly/ “could not rename downloaded file”ANDROID_*signing secrets (same keystore as mobile)