Remove account migration - no more migration - #612
Merged
Conversation
The old-chain account migration window is over: all invalid rows were cleaned from the account_id_mappings table and anon write access was revoked, so the app can no longer upload migrations anyway. - Remove MigrationService, MigrationDialog, and the migration flow from WalletInitializer (including the Supabase upload) - Remove legacy old-accounts storage (accounts v1-v4 keys) and the deferred accountsToMigrate methods from SettingsService - Remove migration l10n strings (en, id) and regenerate localizations - Remove migration tests and stale generated mocks
n13
commented
Aug 16, 2026
n13
left a comment
n13
left a comment
Collaborator
Author
There was a problem hiding this comment.
Verdict: APPROVE
No blocking findings. The migration decommission is internally consistent: wallet initialization no longer invokes the removed flow, the SDK export/API and stale migration tests/mocks/localizations are removed together, the unrelated single-account preferences migration remains intact, and the mining-rewards read-only account_id_mappings lookup is preserved.
Validation:
- Exact head
cbf067c15d6f6f714a2360ade2659536e4ea59b6:git diff --checkand the non-mutating workspace formatting gate passed. - Repository-wide
flutter analyze . --fatal-infospassed across all four packages. - Mobile-app suite: 288 tests passed.
- Non-native quantus_sdk suite: 165 tests passed.
- Refreshed GitHub
Quantus Apps CIpassed all steps on the exact head.
GitHub does not allow authors to formally approve their own PR, so this comment records the approval opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The old-chain account migration window is over.
What
MigrationDialog, migrate/try-later handlers, and the Supabaseaccount_id_mappingsupload.MigrationService(and its export). Removed fromSettingsService: legacy old-accounts storage (accountsv1–v4 keys),hasOldAccounts/getOldAccounts/clearOldAccounts/setOldAccountsData, and the deferred-uploadaccountsToMigratemethods.migration*strings fromapp_en.arb/app_id.arband regenerated the localization classes (pure deletions).SettingsServiceAPI.Kept as-is: the internal single-account→list prefs-format migration in
SettingsService.getAccounts(app storage format, unrelated to chain account migration), and the mining rewards screen's read ofaccount_id_mappings— reward attribution across migrated accounts still works.Net: −1,089 lines.
Testing
quantus_sdk:dart analyzeclean, fullflutter testsuite passes (177 tests)mobile-app: unit suite passes (268 tests), including the wallet-creation tests that use the trimmed mocks