Add bio for authors - #33
Conversation
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT Sol
Verdict: REQUEST_CHANGES — the new default rewrites every existing blog post's byline and structured author attribution without article-level author data.
Blocking findings
- [P1] Preserve the existing team attribution unless a post has a verified person author —
website/src/content.config.ts:15-17andwebsite/src/components/features/blog/BlogPost.astro:30,46-64,117-122. None of the 315 existing blog sources contains anauthor:field, so the new schema default assigns Christopher Smith to every entry. The component then replaces the prior localized “Quantus Team” byline and organization JSON-LD with Christopher's name and Person node across the full archive. That silently republishes historical posts with an unverified individual attribution. Keep the existing organization/team fallback whenauthoris absent and opt posts into person attribution explicitly, or migrate every post with its actual author before changing the rendered byline and JSON-LD. - [P2] Remove the trailing whitespace in
website/bio.md:17andwebsite/bio.md:35. Both added lines failgit diff --check, and Prettier reports the new file. Formatting this file clears the patch-local failure.
Validation
- Reviewed the full diff from
26f68fdc4dda503c27694718ec252fe4cc18a15dtoc0a47e2c8b0521ee4b151c7742ef1d1ff00861bband confirmed the live PR head before posting. PUPPETEER_SKIP_DOWNLOAD=true npx --yes bun install --frozen-lockfilepassed.SITE_BASE_URL=http://localhost:3000 npx --yes bun run buildpassed and generated 1,397 pages, including all 27 localized person routes.SITE_BASE_URL=http://localhost:3000 npx --yes bun run check:seo-metapassed.- A generated-output check resolved all 639 internal links to the new person routes with no missing targets, and all nine locale files contain the complete profile-copy shape.
npx --yes bun run format:checkfailed on 15 files: the newbio.md, plus pre-existing formatter findings and an unchanged section of the modifiedzh-CN.json.
We remove md file of bio because we don't need it. |
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT Sol
Verdict: APPROVE — the prior author-attribution and patch-local formatting blockers are resolved, and no blocking findings remain at 2eba5d4.
The blog author field is now opt-in (website/src/content.config.ts:15-17). Existing posts therefore retain the localized Quantus Team byline and organization JSON-LD, while explicitly authored posts can link to the matching person profile (website/src/components/features/blog/BlogPost.astro:46-67,121-130). The unused bio.md file that caused the earlier whitespace finding has also been removed.
Validation
- Reviewed the complete diff from
26f68fdc4dda503c27694718ec252fe4cc18a15dto the live head2eba5d437a0c51947e12904be17a762e84e6c2c9, plus the incremental changes since the prior reviewed headc0a47e2c8b0521ee4b151c7742ef1d1ff00861bb. git diff --check 26f68fdc4dda503c27694718ec252fe4cc18a15d...HEADpassed.PUPPETEER_SKIP_DOWNLOAD=true npx --yes bun install --frozen-lockfilepassed.SITE_BASE_URL=http://localhost:3000 npx --yes bun run buildpassed and generated 1,397 pages.SITE_BASE_URL=http://localhost:3000 npx --yes bun run check:seo-metapassed.- Generated-output checks confirmed all 27 localized person routes, all nine team-index redirects, organization attribution for existing blog posts, person attribution for the whitepaper, and profile-only sitemap entries.
- Repository-wide
npx --yes bun run format:checkstill reports 14 baseline files. The only warning on a changed filename is an unchanged section ofsrc/i18n/zh-CN.json, which fails identically at the base revision; the PR-added locale block is formatted.
Summary