Repository navigation
update packages - #1
Open
princechauhan1992 wants to merge 266 commits into
Open
princechauhan1992 wants to merge 266 commits into
princechauhan1992 wants to merge 266 commits into
Conversation
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.3 to 1.6.0. - [Release notes](https://github.com/Qix-/color-string/releases) - [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md) - [Commits](https://github.com/Qix-/color-string/commits/1.6.0) --- updated-dependencies: - dependency-name: color-string dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.2...5.2.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.4.7...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/url-parse-1.5.3 Bump url-parse from 1.4.7 to 1.5.3 in /demo
…/ws-5.2.3 Bump ws from 5.2.2 to 5.2.3 in /demo
…/color-string-1.6.0 Bump color-string from 1.5.3 to 1.6.0 in /demo
…/tmpl-1.0.5 Bump tmpl from 1.0.4 to 1.0.5 in /demo
…/path-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7 in /demo
…/merge-deep-3.0.3 Bump merge-deep from 3.0.2 to 3.0.3 in /demo
…/dns-packet-1.3.4 Bump dns-packet from 1.3.1 to 1.3.4 in /demo
…/hosted-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9 in /demo
…/ssri-6.0.2 Bump ssri from 6.0.1 to 6.0.2 in /demo
…/elliptic-6.5.4 Bump elliptic from 6.5.3 to 6.5.4 in /demo
…/ini-1.3.8 Bump ini from 1.3.5 to 1.3.8 in /demo
…/http-proxy-1.18.1 Bump http-proxy from 1.18.0 to 1.18.1 in /demo
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7
…ed-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9
…sh-4.17.21 Bump lodash from 4.17.19 to 4.17.21
…-4.0.1 Bump y18n from 4.0.0 to 4.0.1
…ender Drop label/onOpenChange from the controlled-open effect deps — neither is used in the effect, and their changing identity re-triggered the slide animation on unrelated parent re-renders.
Drop `matches` from the effect deps so the change listener is no longer torn down and re-added on every match flip. Simplify the handler and guard for non-browser environments.
Replace the duplicated per-element switch in MenuItem and SubMenu with a single keyed lookup helper, and build the style params once per render.
Memoize the SidebarContext value so consumers don't re-render when the Sidebar re-renders without a value change, and wrap MenuItem in React.memo so static items skip re-renders on unrelated ancestor updates.
Replace the imperative height/timer animation with a pure CSS transition on grid-template-rows (0fr <-> 1fr). Delete expandContent/collapseContent, the timer ref, the controlled-open effect, and the mounted state. Split the popper effect so the openWhenCollapsed reset only runs on real collapse changes (and add a clearTimeout cleanup for the position-update timer).
Opening a SubMenu in an accordion group closes its siblings. The prop is scoped per level: setting it on Menu coordinates the top-level SubMenus; setting it on a SubMenu coordinates that submenu's direct children. A controlled `open` prop still wins, and the open state is preserved when the accordion prop is later flipped off. Includes unit tests, Storybook stories, and a changelog entry.
Storybook 8+ no longer auto-generates the Docs tab; opt in once at the preview level so every story gets the props table + description + source.
When set on Menu, top-level SubMenus open as floating poppers even while the sidebar is expanded, instead of sliding open inline. Reuses the collapsed-popper machinery via a generalized isPopper flag. Includes unit tests, Storybook story + playground toggle, README and changelog entries (also documents the accordion props in the README).
Storybook 7+ renamed the preview root to #storybook-root; target it (and keep #root) so stories using height:100% fill the canvas again.
Drop EOL Node 18/20 (vitest 4 + size-limit 12 need Node >= 20), pin jobs to Node 24, and add explicit contents:read so checkout can authenticate.
React 18 drops a boolean `inert` and React 19 drops an empty-string one; use "true" so the attribute is present on both.
Fix active styling dropped by the css compiler (falsy && leaked "false" into the style string, invalidating the declaration).
breakPoint now accepts a custom CSS value (e.g. "450px"); customBreakPoint is removed.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| }; | ||
| }, [transitionDuration, toggled, contentRef, buttonRef]); | ||
|
|
||
| return { popperInstance: popperInstanceRef.current }; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
+4
to
+6
| const [matches, setMatches] = React.useState( | ||
| !!breakpoint && typeof window !== 'undefined' && window.matchMedia(breakpoint).matches, | ||
| ); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…inheritance, inert, position-after-mount
V2-ALPHA.1
| border-right-style: solid; | ||
| border-color: #efefef; | ||
|
|
||
| transition: ${({ transitionDuration }) => `width, left, right, ${transitionDuration}ms`}; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| className: classNames(className, classNameProp), | ||
| ...rest, | ||
| ...props, | ||
| ref, |
There was a problem hiding this comment.
Bug: When a component prop with its own event handlers is passed to MenuButton, it overwrites SubMenu's handlers, breaking the toggle functionality.
Severity: HIGH
Suggested Fix
In MenuButton.tsx, reverse the order of the spread props within React.cloneElement. The ...props from the custom component should be spread before ...rest to ensure that the handlers from SubMenu take precedence and are not overwritten.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/components/MenuButton.tsx#L82
Potential issue: In the `MenuButton` component, when a React element with its own event
handlers (e.g., `onClick`) is passed via the `component` prop, its props are spread
after the props passed down from the parent (`SubMenu`). This causes the component's own
`onClick` handler to overwrite the `handleOnClick` handler from `SubMenu`, which is
responsible for toggling the menu's visibility. Consequently, the submenu fails to open
or close on click, breaking its core functionality. This is a documented and
demonstrated use case within the project's examples.
Version Packages (alpha)
chore: setup adsense in website playground
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.