Repository navigation
Conversation
The article is a UIPageViewController, and a no-op pan recognizer on its internal scroll view refuses simultaneous recognition within 40pt of the left edge, so swiping from there doesn't page back and navigate back at the same time. It refused every other recognizer there too, including the split view's reveal gesture. The swipe did nothing over the article while it still worked alongside the toolbars, where the page view controller isn't under the touch. Narrow the refusal to the page view controller's own pan. Paging is still held back near the edge, and everything else gets the touch. Found on an unfolded iPhone Duo, where the article fills a 669pt-wide expanded split view and the timeline is otherwise only reachable from the sidebar button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an unfolded iPhone Duo the article fills a 669pt-wide expanded split view, and swiping in from the left edge to get the timeline back does nothing. The same swipe works if it starts alongside the top or bottom toolbar.
The article is a
UIPageViewController, and a no-op pan recognizer on its internal scroll view refuses simultaneous recognition within 40pt of the left edge, so an edge swipe doesn't page back and navigate back at the same time. The refusal is unconditional:Every recognizer competing for that strip gets turned away, the split view's reveal gesture included. Beside the toolbars the page view controller isn't under the touch, nothing refuses, and the reveal works.
This narrows the refusal to the one recognizer it was aimed at:
Paging is still held back near the edge, so the original behavior is intact. Everything else gets the touch, which leaves
presentsWithGestureto do the reveal and leaves the collapsed case to the navigation controller's pop.Verified on an unfolded iPhone Duo running iOS 27.1. It isn't Duo-specific, though — any expanded split view showing the article by itself runs into it. Related to #5427.