Repository navigation
Fix good job deprecation warning - #1097
Open
zetter-rpf wants to merge 2 commits into
Open
zetter-rpf wants to merge 2 commits into
zetter-rpf wants to merge 2 commits into
Conversation
This warning is for use of `good_job_control_concurrency_with` I've removed the comments that reference it as I think they go into unneeded implementation detail in the tests [1] https://redirect.github.com/bensheldon/good_job/tree/v4.24.1#migrating-from-concurrency-keys-to-labels
When we upgrade good job, it's good practice to run any new migrations with: bin/rails g good_job:update
Test coverage94.18% line coverage reported by SimpleCov. |
zetter-rpf
marked this pull request as ready for review
November 6, 2026 16:44
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Beyond replacing the deprecated Salesforce concurrency API, this runs substantial shared job-database migrations during release. Confirm production capacity and the deployment/recovery plan, since concurrent index operations still impose database load and can affect existing queues. Needs human approval because:
You can add or adjust custom eligibility rules. Learn more. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a good job depreciation warning that I saw locally
I've also set up the latest migrations required by good job.
See commits for more