Rails 7 -> 8.0.5#815
Open
abcampo-iry wants to merge 2 commits into
Open
Conversation
Test coverage91.05% line coverage reported by SimpleCov. |
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the application from Rails 7.2 to Rails 8.x, updating configuration defaults, strong-parameter handling, and tests to match new Rails behaviors (notably ActionController::Parameters#expect and updated exception messages).
Changes:
- Bump Rails dependency and framework defaults to Rails 8 (Gemfile/Gemfile.lock +
config.load_defaults). - Replace
require(...).permit(...)strong params withparams.expect(...)in several API controllers. - Adjust request/spec helpers for rake task loading/reenabling and update brittle expectation(s) affected by Rails 8.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/requests/test_utilities_spec.rb | Updates rake task handling around request specs. |
| spec/requests/api_controller_spec.rb | Updates expected ParameterMissing error message for Rails 8. |
| spec/rails_helper.rb | Loads rake tasks once per suite and reenables tasks around type: :task specs. |
| spec/features/school_class/listing_school_classes_spec.rb | Makes assertions order-independent by locating classes by name. |
| Gemfile.lock | Resolves Rails and related gems to Rails 8.x versions. |
| Gemfile | Updates Rails dependency requirement to ~> 8.0.4. |
| config/application.rb | Updates config.load_defaults to 8.0. |
| app/controllers/api/subscriptions_controller.rb | Switches strong params to params.expect. |
| app/controllers/api/schools_controller.rb | Switches strong params to params.expect. |
| app/controllers/api/school_teachers_controller.rb | Switches strong params to params.expect. |
| app/controllers/api/school_students_controller.rb | Switches strong params to params.expect. |
| app/controllers/api/school_classes_controller.rb | Switches strong params to params.expect. |
| app/controllers/api/projects/remixes_controller.rb | Switches strong params to params.expect (includes nested params). |
| app/controllers/api/google_auth_controller.rb | Switches strong params to params.expect. |
| app/controllers/api/class_members_controller.rb | Switches strong params to params.expect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
It has been upgraded rails 7 to rails 8.0.4 following the conversations from the Issue above and #784