Fix Streamable.forEach BiConsumer overload ignoring executor - #8302
Merged
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.367 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8302 +/- ##
============================================
- Coverage 98.62% 98.58% -0.05%
Complexity 7157 7157
============================================
Files 824 824
Lines 50800 50800
Branches 6913 6913
============================================
- Hits 50104 50080 -24
- Misses 474 487 +13
- Partials 222 233 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akarnokd
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the BiConsumer overload of Streamable.forEach() ignoring its ExecutorService.
The overload currently calls CompletableFuture.supplyAsync(...) without passing the provided executor. As a result, the blocking stream consumption runs on ForkJoinPool.commonPool() instead of the executor supplied by the caller.
This also affects Streamable.transform(transformer, executor), which delegates to the same BiConsumer overload.