Fresh interface, split off implementations - #89
Merged
Conversation
Fix a bug with `Asynchronous` schedules
…se`, and `Graphs`.
`[workspace]`s are only supported from 1.12 onward and I want to use them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 94.05% 88.37% -5.69%
==========================================
Files 2 5 +3
Lines 101 43 -58
==========================================
- Hits 95 38 -57
+ Misses 6 5 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to new version of the interface and break out implementations to separate packages.
The main difference with the previous interface is that the "graph-ness" (
verticesandedgesfunctions) and the "dynamical-system-ness" (schedule_style,update_function,get_state, andset_state!functions) are both expected to be implemented for a type implementing the interface.The previous version assumed that the type would be
<: GraphDynamicalSystem, locking it into the type hierarchy of this package, which is exactly what I'd like to avoid. Types should be able to hook into the interface without having to be within the hierarchy. With this new version, the only thing necessary is for someone to implement the necessary methods from the GDS interface and that should be enough.Checklist