Skip to content

Fresh interface, split off implementations - #89

Merged
ReubenJ merged 18 commits into
mainfrom
feat/fresh-interface
Aug 12, 2026
Merged

Fresh interface, split off implementations#89
ReubenJ merged 18 commits into
mainfrom
feat/fresh-interface

Conversation

@ReubenJ

@ReubenJ ReubenJ commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Update to new version of the interface and break out implementations to separate packages.

The main difference with the previous interface is that the "graph-ness" (vertices and edges functions) and the "dynamical-system-ness" (schedule_style, update_function, get_state, and set_state! functions) are both expected to be implemented for a type implementing the interface.

The previous version assumed that the type would be <: GraphDynamicalSystem, locking it into the type hierarchy of this package, which is exactly what I'd like to avoid. Types should be able to hook into the interface without having to be within the hierarchy. With this new version, the only thing necessary is for someone to implement the necessary methods from the GDS interface and that should be enough.

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.37%. Comparing base (f1c1e34) to head (6bc67a8).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
ext/DynamicalSystemsBaseExt.jl 84.21% 3 Missing ⚠️
ext/GraphsExt.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   94.05%   88.37%   -5.69%     
==========================================
  Files           2        5       +3     
  Lines         101       43      -58     
==========================================
- Hits           95       38      -57     
+ Misses          6        5       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ReubenJ
ReubenJ marked this pull request as ready for review August 12, 2026 07:40
@ReubenJ
ReubenJ merged commit 6bc67a8 into main Aug 12, 2026
4 of 8 checks passed
@ReubenJ
ReubenJ deleted the feat/fresh-interface branch August 12, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants