Repository navigation
Add fuse - #108
Merged
Merged
Add fuse#108
Conversation
Ports RoboStack/ros-lyrical#85: fuse_graphs adds the GCC-only -Wno-maybe-uninitialized only for GCC (clang rejects it with -Werror), and fuse_viz builds against Qt6 where rviz does (lyrical, rolling). Co-authored-by: Kamil Baradziej <49471097+baradejoo@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…[skip ci] Turns the local checks of this PR into a recipe test, so later rebuilds keep them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Human Tobi: looks good to go once the sync PRs are in |
Export all symbols of the fuse libraries, skip GCC/Clang-only -Wall -Werror with MSVC (fuse_graphs, fuse_constraints), define _USE_MATH_DEFINES on fuse_core and its dependents for M_PI, and run the fuse_optimizers smoke test on Windows as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fuse 1.1.6's imu_2d.cpp exceeds the object file section limit (C1128); lyrical's 1.3.4 builds without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
imu_2d.cpp has more sections than an object file can hold (C1128: number of sections exceeded object file format limit), seen with rolling's newer dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The macOS jobs ran for hours: after SIGTERM fixed_lag_smoother_node kept running and held the test's output open, so rattler-build waited for it (as rko_lio's test did). Kill it after 3 s and wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ABI check (linux-64)About this checkEach package this pull request built, compared with its newest released build (
Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison. |
Tobias-Fischer
enabled auto-merge (squash)
October 25, 2026 11:02
Tobias-Fischer
disabled auto-merge
October 25, 2026 11:07
Tobias-Fischer
enabled auto-merge (squash)
October 25, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports RoboStack/ros-lyrical#85 by @baradejoo: adds
fuse(all fuse packages andtf2_2d) to the shared selection, on all platforms.fuse_graphs(shared patch):-Wno-maybe-uninitializedonly for GCC; clang rejects it with-Werror.CMAKE_WINDOWS_EXPORT_ALL_SYMBOLSfor the fuse libraries (shared/pkg_additional_info.yaml);fuse_graphs(shared patch) andfuse_constraints(.win.patch) skip their GCC/Clang-Wall -Werrorwith MSVC;fuse_core(.win.patch) defines_USE_MATH_DEFINESpublicly forM_PI;fuse_models(jazzy.win.patch, fuse 1.1.6) compiles with/bigobj.fuse_viz(lyrical, rolling): Qt6 like their rviz; jazzy's rviz is Qt5, so jazzy needs no patch. humble has no fuse release.Recipe test:
fuse_optimizers'fixed_lag_smoother_nodestarts and keeps running (shared/tests/ros2-fuse-optimizers.yaml), now on Windows too.CI (jazzy, lyrical): lyrical win-64 builds all fuse packages and the smoother node starts; jazzy win-64 needed the
fuse_models/bigobjfix.Built locally
fuse_vizand their recipe tests;fuse_optimizers'fixed_lag_smoother_nodeandbatch_optimizer_nodeare installed and the smoother starts.fuse_viz, with their recipe tests.fuse_viz, with their recipe tests.Prepared and built on top of the current rosdistro syncs (#62 humble, #61 jazzy, #60 lyrical, #99 rolling) merged together, so it targets their package versions: merge after them. The syncs are merged now; CI builds jazzy and lyrical (
build:labels).🤖 Generated with Claude Code