Grader LTI bugfix and force send all updates - #1584
Open
ascholerChemeketa wants to merge 2 commits into
Open
ascholerChemeketa wants to merge 2 commits into
ascholerChemeketa wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unconditional forcing bypasses LTI settings for student submissions, while direct instructor edits still are not forced.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds forced LTI score resending to the regrade workflow across the UI, API, grading logic, and tests.
Changes:
- Adds an instructor-facing resend option.
- Propagates force flags through backend LTI updates.
- Adds frontend and backend coverage.
| File | Description |
|---|---|
test/components/rsptx/grading_helpers/test_regrade_batch.py |
Tests forced and unchanged-score pushes. |
components/rsptx/grading_helpers/regrade.py |
Implements forced LTI resending. |
bases/rsptx/assignment_server_api/routers/grader.py |
Accepts and forwards the option. |
bases/rsptx/assignment_server_api/assignment_builder/src/store/grader/grader.logic.api.ts |
Extends the request interface. |
bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/Grader/components/RegradeWizard.tsx |
Adds the resend checkbox. |
bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/Grader/components/RegradeWizard.spec.tsx |
Tests UI request behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| changes, | ||
| user_map, | ||
| push_unchanged=options.resend_all_scores_via_lti, | ||
| force=True, |
Comment on lines
+410
to
+413
| assert lti_mock.await_args.kwargs == { | ||
| "force": False, | ||
| "instructor_triggered": True, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit makes sure that instructor grade changes get sent via LTI even if "auto updates" are turned off.
Second adds a checkbox to the regrade wizard so instructors can forcibly resend even unchanged grades to LTI. Default is false.
This is useful if you do something like change grade reporting from points to percent, open an assignment in your LMS that some students had already done on the RS side, etc...
This pull request introduces a new option to the regrade workflow that allows instructors to force the resending of all assignment totals via LTI, even if the scores have not changed. This affects both the frontend and backend, ensuring that the new option is available in the UI, passed through the API, and handled correctly in the grading logic. Additional tests have been added to verify the new behavior and its interaction with existing options.
Key changes include:
Frontend (UI and API integration):
RegradeWizardUI, which defaults to off and is included in both preview and run requests. When enabled, it also forces "Recompute assignment totals" to be enabled and disables its checkbox. [1] [2] [3] [4]RegradeRequestinterface to include the newresend_all_scores_via_ltiboolean property, ensuring the option is sent to the backend.Backend (API and logic):
RegradeRequestandRegradeOptions) and endpoints to accept and forward theresend_all_scores_via_ltiflag. [1] [2] [3] [4]forceflag is now forwarded through the relevant functions to support this behavior. [1] [2] [3] [4] [5]Testing:
forceflag is handled correctly throughout the stack. [1] [2] [3] [4]Other: