Repository navigation
fix(spirv-builder): remove unwraps from SpirvWatcher - #690
Closed
sorinirimies wants to merge 1 commit into
Closed
sorinirimies wants to merge 1 commit into
sorinirimies wants to merge 1 commit into
Conversation
- Non-UTF-8 dep-file paths (non-Unix only) are logged and skipped instead of panicking the watcher. - `recv` no longer unwraps the build result of `recv_inner`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two
unwrap()s fromSpirvWatcherthat could take down a long-running watch loop.A blocking
recvnever reportsEmpty, so the loop is only reached if that invariant breaks — and waiting for the next change is the correct fallback there instead of a panic.Evidence
New tests in
watch::tests:cargo test -p spirv-builder --features watch,clap: 7 passed. Clippy-D warningsclean. The non-Unix branch ofdep_to_path_non_utf8is exercised by Windows CI.Merge Danger
Door: two-way
Blast Radius: small —
watchfeature only; behavior changes solely in the previously-panicking cases.