Repository navigation
fix(spirv-builder): error instead of panic when cargo can't be spawned - #694
Closed
sorinirimies wants to merge 1 commit into
Closed
sorinirimies wants to merge 1 commit into
sorinirimies wants to merge 1 commit into
Conversation
- `cargo.output().expect(..)` -> new `SpirvBuilderError::CargoSpawnFailed` (the enum is `#[non_exhaustive]`). - Decode cargo's stdout lossily instead of unwrapping `from_utf8`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two more panics in
SpirvBuilder::invoke_rustc(follow-up to #689):New variant
SpirvBuilderError::CargoSpawnFailed(io::Error)— "failed to runcargo: {0}". Lossy decoding is fine: cargo's JSON messages are UTF-8, anything else on stdout is only forwarded to the user.Evidence
multibuilderwithcargoabsent fromPATH(onlyrustcpresent;CARGOset socargo metadatastill works):Before (main) — panic inside
spirv-builder:After —
build()returnsErr; the panic is the example's own.unwrap():Clippy
-D warningsclean.Merge Danger
Door: two-way
Blast Radius: tiny —
SpirvBuilderErroris#[non_exhaustive]; only previously-panicking paths change.