Repository navigation
Conversation
The C++ frames of translated exceptions were added with _PyTraceback_Add, which became private in Python 3.13, so tracebacks lost them. Build them as real traceback entries instead: for each C++ frame, compile a one-line raise whose code object carries the C++ file, line and function name, run it to get a frame, and chain the entries with types.TracebackType. The translated exception gets this chain before it is raised. This only runs when a C++ exception is translated. Fixes SFTtech#1700 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1700.
Since
_PyTraceback_Addbecame private in Python 3.13, translated C++ exceptions lost their C++ frames in Python tracebacks. This builds them as real traceback entries instead, using only public API: for each C++ frame, a one-lineraiseis compiled into a code object that carries the C++ file, line and function name (no column info). Running it gives a frame, and the entries are chained withtypes.TracebackType. The translated exception gets this chain viawith_traceback()before it is raised.This happens in
raise_cpp_error, the translator that Cython'sexcept +handler calls via__Pyx_CppExn2PyErr, so there is no overhead unless a C++ exception is actually translated.cpp_to_py_demowith Python 3.14:cppinterface.exctranslate_tests.cpp_to_pynow also checks that the C++ throw location is part of the traceback.🤖 Generated with Claude Code