Repository navigation
Add BigLDAP topology - #251
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new BigLDAPTopologyController and its corresponding topology mark BigLDAP to support LDAP topologies with large amounts of users and groups. The feedback points out several issues in the topology_setup implementation of BigLDAPTopologyController, including bypassing the self.provisioned check, hardcoding service management commands and instance names instead of using existing abstractions, and missing error handling decorators. A refactoring suggestion is provided to address these issues.
thalman
marked this pull request as ready for review
June 3, 2026 12:45
thalman
marked this pull request as draft
June 3, 2026 12:46
thalman
marked this pull request as ready for review
June 23, 2026 08:16
Member
|
@thalman, do you have test example (maybe in your repo fork) that uses new topology? |
thalman
force-pushed
the
big_ldap
branch
3 times, most recently
from
August 12, 2026 17:44
ccb843b to
e0c2f04
Compare
alexey-tikhonov
approved these changes
Aug 25, 2026
pbrezina
approved these changes
Aug 31, 2026
This patch expects that ldap container/vm has ldap backup 'largedata'. This backup is restored when BigLDAP topology is used. Restore process is quite fast (~2s).
Default teardown deletes objects in LDAP one by one to achive original state. This takes a lot of time. This update restores base (empty) LDAP backup before calling super().topology_teardown()
Contributor
Author
|
last force-push is just rebase |
Contributor
Author
|
CI failure is not caused by this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch expects that ldap container/vm has ldap backup 'largedata'. This backup is restored when BigLDAP topology is used.
Restore process is quite fast (~2s).