Skip to content

Adcs smartcard setup v2 - #255

Merged
spoore1 merged 4 commits into
SSSD:masterfrom
spoore1:adcs_smartcard_setup_v2
Aug 21, 2026
Merged

Adcs smartcard setup v2#255
spoore1 merged 4 commits into
SSSD:masterfrom
spoore1:adcs_smartcard_setup_v2

Conversation

@spoore1

@spoore1 spoore1 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • AD role: change Enrollment Agent name

Changing the default Certificate Template name for the Enrollment Agent template from EnrollmentAgent4 to EnrollmentAgent_IDMTEST.

  • topology_controller: update join_domain for ad

Updates for better AD support including with smart card tests that require a pkinit_anchor for the krb5 config.

Also backing up krb5.conf and krb5.keytab to make setup/teardown a little cleaner.

Skipping krb5.conf removal for AD tests so there is a functional version for use.

  • Re-Enable AD CA along with containers update

Re-enabling AD CA role support for smart card testing to align with sssd-ci-containers change to enable this funtionality.

Depends-on: SSSD/sssd-ci-containers#174

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables AD Certificate Authority functionality and updates the certificate template name in sssd_test_framework/roles/ad.py. It also modifies sssd_test_framework/topology_controllers.py to back up Kerberos configuration files, skip removing krb5.conf for AD providers, and write a custom ad_pkinit configuration. Feedback was provided regarding the indentation of the closing triple quotes in the textwrap.dedent block, which prevents proper dedenting of the generated configuration, along with a suggestion to simplify the isinstance check.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sssd_test_framework/topology_controllers.py Outdated
@spoore1
spoore1 requested a review from krishnavema July 1, 2026 13:14
@spoore1
spoore1 force-pushed the adcs_smartcard_setup_v2 branch 3 times, most recently from 36ad3a5 to abecbd1 Compare July 20, 2026 23:40
@spoore1
spoore1 force-pushed the adcs_smartcard_setup_v2 branch from abecbd1 to 3252de9 Compare August 19, 2026 19:54
Changing the default Certificate Template name for the Enrollment Agent
template from EnrollmentAgent4 to EnrollmentAgent_IDMTEST.
Updates for better AD support including with smart card tests that
require a pkinit_anchor for the krb5 config.

Also backing up krb5.conf and krb5.keytab to make setup/teardown a
little cleaner.

Skipping krb5.conf removal for AD tests so there is a functional version
for use.
Re-enabling AD CA role support for smart card testing to align with
sssd-ci-containers change to enable this funtionality.

Depends-on: SSSD/sssd-ci-containers#174
In some environments, the stdin password pipe for an openssl command in
the ad.ca.request() method fails with invalid password.  Removing the
pipe and setting it directly from the command line.

The AD CA is not always configured with the name forced to ad-RootCA.
Changing to use _get_ca_config() to determine the CA name to use.
@spoore1
spoore1 force-pushed the adcs_smartcard_setup_v2 branch from 3252de9 to eefef5a Compare August 21, 2026 18:00
@spoore1

spoore1 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Locally ran the system tests against fedora-latest containers with this result:

=========================== short test summary info ============================
FAILED tests/test_kcm.py::test_kcm__tgt_renewal_updates_ticket_as_configured (client)
FAILED tests/test_sudo.py::test_sudo__ldap_sudo_search_base_not_set_emits_warning (ldap)
FAILED tests/test_ldap_krb5.py::test_ldap_krb5__keytab_selects_correct_principal_with_multiple_realms (ldap_krb5)
FAILED tests/test_gpo.py::test_gpo__rejects_path_traversal_in_gpo_file_sys_path (samba)
= 4 failed, 618 passed, 26 skipped, 316 deselected, 1 xfailed in 9084.17s (2:31:24) =

Will merge this now.

@spoore1
spoore1 merged commit 9014929 into SSSD:master Aug 21, 2026
5 of 6 checks passed
@spoore1
spoore1 deleted the adcs_smartcard_setup_v2 branch August 21, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants