Skip to content

Add authselect to LDAP and Client Topo Controllers - #267

Merged
justin-stephenson merged 1 commit into
SSSD:masterfrom
spoore1:tests_ldap_auth_fixes
Aug 18, 2026
Merged

Add authselect to LDAP and Client Topo Controllers#267
justin-stephenson merged 1 commit into
SSSD:masterfrom
spoore1:tests_ldap_auth_fixes

Conversation

@spoore1

@spoore1 spoore1 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

LDAP provider authentication tests are failing because authselect is not run. Adding a basic topology_setup to run authselect select sssd.

Some client topology tests are failing the same way. Adding authselect there as well.

@spoore1
spoore1 force-pushed the tests_ldap_auth_fixes branch 3 times, most recently from e1dff2e to e96039b Compare August 10, 2026 21:16
LDAP provider authentication tests are failing because authselect is not
run.  Adding a basic topology_setup to run authselect select sssd.

Some client topology tests are failing the same way.  Adding authselect
there as well.

@justin-stephenson justin-stephenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed based on this comment https://github.com/SSSD/sssd/blob/master/src/tests/system/tests/test_authentication.py#L270 ?? or do I misunderstand

@spoore1

spoore1 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

This should not be needed based on this comment https://github.com/SSSD/sssd/blob/master/src/tests/system/tests/test_authentication.py#L270 ?? or do I misunderstand

I saw that comment but, I could not find where client.sssd.start() actually ran authselect. I could move this to that method if we want to implement it everywhere but, that seemed like a more invasive change than just patching the failing topologies. We don't have the same problems in IPA and AD because we use realm join which handles the authselect for us.

@justin-stephenson

Copy link
Copy Markdown
Contributor

This should not be needed based on this comment https://github.com/SSSD/sssd/blob/master/src/tests/system/tests/test_authentication.py#L270 ?? or do I misunderstand

I saw that comment but, I could not find where client.sssd.start() actually ran authselect. I could move this to that method if we want to implement it everywhere but, that seemed like a more invasive change than just patching the failing topologies. We don't have the same problems in IPA and AD because we use realm join which handles the authselect for us.

Okay thanks for the explanation.

@justin-stephenson
justin-stephenson merged commit 76b26d0 into SSSD:master Aug 18, 2026
6 checks passed
@spoore1
spoore1 deleted the tests_ldap_auth_fixes branch August 21, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants