Conversation
danlavu
marked this pull request as draft
August 13, 2026 19:17
danlavu
force-pushed
the
remove-intg-tests
branch
2 times, most recently
from
August 14, 2026 16:09
4546d2a to
7d942b8
Compare
alexey-tikhonov
self-requested a review
August 17, 2026 18:43
danlavu
force-pushed
the
remove-intg-tests
branch
from
August 19, 2026 13:43
7d942b8 to
ca68053
Compare
danlavu
marked this pull request as ready for review
August 27, 2026 13:38
Member
|
@danlavu There are conflicts, please rebase. |
danlavu
force-pushed
the
remove-intg-tests
branch
from
August 31, 2026 15:33
ca68053 to
f108ab8
Compare
alexey-tikhonov
removed their request for review
September 1, 2026 12:13
Member
|
@danlavu, is it still 'Blocked'? |
Remove src/tests/intg and all associated build infrastructure now that the relevant tests have been ported to src/tests/system. - Delete src/tests/intg/ and src/external/intgcheck.m4 - Remove intgcheck job from .github/workflows/ci.yml - Remove intgcheck targets from Makefile.am - Remove intgcheck m4_include and Makefile output from configure.ac - Remove intgcheck entry from contrib/ci/get-matrix.py - Remove intgcheck logic from contrib/ci/run and contrib/ci/deps.sh AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
remove-intg-tests
branch
from
September 23, 2026 16:04
f108ab8 to
e7eb7bb
Compare
Contributor
Author
|
@alexey-tikhonov, sorry I missed your comment, yes, but now it is not. |
alexey-tikhonov
self-requested a review
September 23, 2026 17:00
Member
|
I suggest to keep make valgrind check (move it somewhere, maybe to make distcheck?) |
Contributor
Author
Ack, will update the PR. |
The intgcheck workflow was the only CI coverage of unit tests under Valgrind. Move that memcheck run to make-distcheck so it is not lost with the legacy intg suite. AI: Cursor Grok 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove src/tests/intg and all associated build infrastructure now that
the relevant tests have been ported to src/tests/system.
Depends on
AI: Claude Sonnet 4.6
Co-authored-by: Cursor cursoragent@cursor.com