nss: fix potential memory leak if packet grow fails - #9103
Open
pbrezina wants to merge 1 commit into
Open
Conversation
sumit-bose
reviewed
Aug 20, 2026
| /* First two fields (length and reserved), filled up later. */ | ||
| ret = sss_packet_grow(packet, 2 * sizeof(uint32_t)); | ||
| if (ret != EOK) { | ||
| talloc_free(tmp_ctx); |
Contributor
There was a problem hiding this comment.
Hi,
thank you for the fixes. Is there a reason you didn't use goto done; which would be more in line with the other error handling in this and the other functions and sets the size of the packet to zero?
bye,
Sumit
aplopez
self-requested a review
August 20, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.