Skip to content

chore: migrate flying-toasters to standalone repo#866

Open
nicomiguelino wants to merge 1 commit into
masterfrom
chore/remove-flying-toasters
Open

chore: migrate flying-toasters to standalone repo#866
nicomiguelino wants to merge 1 commit into
masterfrom
chore/remove-flying-toasters

Conversation

@nicomiguelino

@nicomiguelino nicomiguelino commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

User description

Removes source files from edge-apps/flying-toasters and redirects to Screenly/flying-toasters-app. Closes #826.


PR Type

Other, Documentation


Description

  • Remove monorepo Flying Toasters source

  • Redirect documentation to standalone repository

  • Update root app catalog link


Diagram Walkthrough

flowchart LR
  monorepo["Playground flying-toasters app"]
  standalone["Screenly/flying-toasters-app"]
  docs["README links"]
  monorepo -- "source removed" --> standalone
  docs -- "redirects users" --> standalone
Loading

File Walkthrough

Relevant files
Cleanup
2 files
base.css
Remove Flying Toasters base stylesheet                                     
+0/-43   
index.html
Remove Flying Toasters HTML implementation                             
+0/-372 
Documentation
3 files
README.md
Point app catalog to standalone repository                             
+1/-1     
README.md
Replace app docs with migration notice                                     
+2/-25   
README.ChicagoFLF
Remove bundled font license notes                                               
+0/-23   
Configuration changes
2 files
screenly.yml
Remove production Screenly app manifest                                   
+0/-9     
screenly_qc.yml
Remove QC Screenly app manifest                                                   
+0/-9     

- remove source files from edge-apps/flying-toasters
- redirect README to Screenly/flying-toasters-app
- update root README entry
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 7b01cde)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

826 - PR Code Verified

Compliant requirements:

  • Migrate edge-apps/flying-toasters out of the Playground monorepo.
  • Redirect users/documentation from the monorepo location to the standalone repository.

Requires further human verification:

  • Move the app to the standalone repository Screenly/flying-toasters-app.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Remove orphan app directory

Keeping edge-apps/flying-toasters as a directory without its app manifest/assets can
break tooling that scans edge-apps/* as installable apps. Remove this tombstone file
or move the migration note outside edge-apps so the deleted app is not still
discovered as a local app.

edge-apps/flying-toasters/README.md [1-3]

-# Flying Toasters App
 
-This app has been moved to its own repository: [Screenly/flying-toasters-app](https://github.com/Screenly/flying-toasters-app/)
Suggestion importance[1-10]: 7

__

Why: The existing_code matches the remaining tombstone README.md, and keeping edge-apps/flying-toasters as a directory after deleting its manifest could plausibly break tooling that treats each edge-apps/* directory as an app. The impact is potentially meaningful, though somewhat speculative without seeing the repository tooling.

Medium

@nicomiguelino nicomiguelino marked this pull request as ready for review June 27, 2026 05:06
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 7b01cde

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: migrate edge-apps/flying-toasters to standalone repo (Screenly/flying-toasters-app)

1 participant