Repository navigation
fix(Dropdown): add icon class for item - #4545
Open
aishwaryaa0509-bit wants to merge 1 commit into
Open
aishwaryaa0509-bit wants to merge 1 commit into
aishwaryaa0509-bit wants to merge 1 commit into
Conversation
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
@aishwaryaa0509-bit is attempting to deploy a commit to the Semantic UI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the missing
iconclass when a Dropdown is used as an item with an icon.Changes
iconclass to the Dropdown root element when theiconprop is provided.itemandiconprops.Testing
itemandiconclasses.git diff --checkpasses.Fixes #642