Skip to content

fix(Dropdown): add icon class for item - #4545

Open
aishwaryaa0509-bit wants to merge 1 commit into
Semantic-Org:masterfrom
aishwaryaa0509-bit:fix/dropdown-menu-item-icon
Open

aishwaryaa0509-bit wants to merge 1 commit into
Semantic-Org:masterfrom
aishwaryaa0509-bit:fix/dropdown-menu-item-icon

Conversation

@aishwaryaa0509-bit

Copy link
Copy Markdown

Description

Fixes the missing icon class when a Dropdown is used as an item with an icon.

Changes

  • Added the icon class to the Dropdown root element when the icon prop is provided.
  • Added a regression test covering a Dropdown with both item and icon props.

Testing

  • Added a regression test for the expected item and icon classes.
  • git diff --check passes.
  • The test suite could not be executed because the repository's Gulp setup is incompatible with the currently active Node.js version.

Fixes #642

@welcome

welcome Bot commented Sep 18, 2026

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

@aishwaryaa0509-bit is attempting to deploy a commit to the Semantic UI Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Dropdown): support MenuItem and Button types

1 participant