Skip to content

feat(catalog): show 8K/1K for GLM-5.2 / feat(catalog)：为 GLM-5.2 显示 8K/1K #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oseltamivir merged 2 commits into from
Nov 14, 2026
Merged

feat(catalog): show 8K/1K for GLM-5.2 / feat(catalog)：为 GLM-5.2 显示 8K/1K #1781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e9a73
feat(catalog): show 8K/1K for GLM-5.2
Oseltamivir Nov 14, 2026
3b46251
test: un-retire GLM-5.2 8K/1K in options route test; re-pin video his…
Oseltamivir Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/app/src/app/api/v1/views/options/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,15 @@ describe('GET /api/v1/views/options', () => {
expect(agentic.isl).toBeNull();
});

it('keeps Flash 8K/1K active independently of the non-Flash GLM retirement', async () => {
it('keeps 8K/1K active for both GLM-5.3-Flash and GLM-5.2', async () => {
const res = await GET(request('/api/v1/views/options'));
const body = await res.json();
const flash = body.models.find((model: { name: string }) => model.name === 'GLM-5.3-Flash');
const nonFlash = body.models.find((model: { name: string }) => model.name === 'GLM-5.2');
expect(flash.deprecatedSequences).not.toContain('8k/1k');
expect(flash.deprecatedSequences).not.toContain('agentic-traces');
expect(flash.deprecatedSequences).toContain('1k/1k');
expect(nonFlash.deprecatedSequences).toContain('8k/1k');
expect(nonFlash.deprecatedSequences).not.toContain('8k/1k');
});

it('returns default models in selector order without changing the selected default', async () => {
Expand Down
9 changes: 3 additions & 6 deletions packages/app/src/lib/catalog/data-mappings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,13 +528,10 @@ describe('isSequenceHiddenForModel', () => {
).toEqual([Sequence.EightK_OneK, Sequence.AgenticTraces]);
expect(getSequenceCategoryForModel(Sequence.EightK_OneK, Model.GLM_5_3_Flash)).toBe('default');
});
it('hides 8K/1K for GLM-5.2 / GLM-5.3 and keeps Agentic coding', () => {
expect(isSequenceHiddenForModel(Model.GLM_5_2, Sequence.EightK_OneK)).toBe(true);
it('shows 8K/1K and Agentic coding for GLM-5.2 / GLM-5.3', () => {
expect(isSequenceHiddenForModel(Model.GLM_5_2, Sequence.EightK_OneK)).toBe(false);
expect(isSequenceHiddenForModel(Model.GLM_5_2, Sequence.AgenticTraces)).toBe(false);
});

it('also marks the hidden GLM 8K/1K retired for category consumers', () => {
expect(getSequenceCategoryForModel(Sequence.EightK_OneK, Model.GLM_5_2)).toBe('deprecated');
expect(getSequenceCategoryForModel(Sequence.EightK_OneK, Model.GLM_5_2)).toBe('default');
expect(getSequenceCategoryForModel(Sequence.AgenticTraces, Model.GLM_5_2)).toBe('default');
});

Expand Down
2 changes: 0 additions & 2 deletions packages/app/src/lib/catalog/data-mappings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@ const MODEL_DEPRECATED_SEQUENCES: Partial<Record<Model, ReadonlySet<Sequence>>>
[Model.Qwen3_5]: new Set([Sequence.EightK_OneK]),
[Model.MiniMax_M3]: new Set([Sequence.EightK_OneK]),
[Model.DeepSeek_V4_Pro]: new Set([Sequence.EightK_OneK]),
[Model.GLM_5_2]: new Set([Sequence.EightK_OneK]),
};

export function isSequenceDeprecatedForModel(model: Model, sequence: Sequence): boolean {
Expand All @@ -468,7 +467,6 @@ const MODEL_HIDDEN_SEQUENCES: Partial<Record<Model, ReadonlySet<Sequence>>> = {
[Model.Muse_Spark_Open]: new Set(
SEQUENCE_OPTIONS.filter((sequence) => sequence !== Sequence.AgenticTraces),
),
[Model.GLM_5_2]: new Set([Sequence.EightK_OneK]),
};

export function isSequenceHiddenForModel(model: Model, sequence: Sequence): boolean {
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/lib/video/video-history-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ describe('history projection version', () => {
hash.update(relative(root, file)).update(readFileSync(file));
expect({ projection: VIDEO_HISTORY_PROJECTION, sources: hash.digest('hex') }).toEqual({
projection: 4,
// The TCO basis selector models changed; recorded video entries are unchanged.
sources: '7954b0c06216ef719146017da85073d24a393decb606cd6fb0f1f9417b7d4ab0',
// GLM-5.2 8K/1K left the model sequence retirement maps; recorded video entries are unchanged.
sources: 'b028e29c68277a2e6d1c0730306a0796984d62293624824713f924bf67666ab9',
});
});
});
Loading