Skip to content

[Security] Harden relative path sanitization#7607

Draft
gonzaloriestra wants to merge 2 commits into
mainfrom
jules-security-harden-relative-path-sanitization-6026173477022661726
Draft

[Security] Harden relative path sanitization#7607
gonzaloriestra wants to merge 2 commits into
mainfrom
jules-security-harden-relative-path-sanitization-6026173477022661726

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Improves path sanitization to prevent potential absolute path escapes and directory traversal in commands that use sanitizeRelativePath.

WHAT is this pull request doing?

Hardens sanitizeRelativePath to strip leading slashes (Unix absolute paths), multiple slashes, and Windows drive letters. This ensures that when the sanitized path is joined with a base directory, it cannot escape to arbitrary locations on the filesystem. Added comprehensive unit tests to verify these new sanitization rules.

How to test your changes?

CI

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (`patch` for bug fixes · `minor` for new features · `major` for breaking changes) and added a changeset with `pnpm changeset add`

PR created automatically by Jules for task 6026173477022661726 started by @gonzaloriestra

Hardens sanitizeRelativePath to strip leading slashes, multiple slashes,
and Windows drive letters. This prevents absolute path injection from
escaping intended base directories. Added regression tests in
path.test.ts.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 22, 2026
- Hardens `sanitizeRelativePath` to strip leading slashes and Windows drive letters.
- Updates E2E tests for CLI v4:
  - Replaces obsolete `--force` flag with `--allow-updates` in `deployApp` helper.
  - Updates `smoke-pty` test to expect version `4.` instead of `3.`.
  - Updates snapshots for installation warnings.
- Added regression tests for path sanitization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant