[Security] Harden relative path sanitization#7607
Conversation
Hardens sanitizeRelativePath to strip leading slashes, multiple slashes, and Windows drive letters. This prevents absolute path injection from escaping intended base directories. Added regression tests in path.test.ts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Hardens `sanitizeRelativePath` to strip leading slashes and Windows drive letters. - Updates E2E tests for CLI v4: - Replaces obsolete `--force` flag with `--allow-updates` in `deployApp` helper. - Updates `smoke-pty` test to expect version `4.` instead of `3.`. - Updates snapshots for installation warnings. - Added regression tests for path sanitization.
WHY are these changes introduced?
Improves path sanitization to prevent potential absolute path escapes and directory traversal in commands that use
sanitizeRelativePath.WHAT is this pull request doing?
Hardens
sanitizeRelativePathto strip leading slashes (Unix absolute paths), multiple slashes, and Windows drive letters. This ensures that when the sanitized path is joined with a base directory, it cannot escape to arbitrary locations on the filesystem. Added comprehensive unit tests to verify these new sanitization rules.How to test your changes?
CI
Post-release steps
Checklist
PR created automatically by Jules for task 6026173477022661726 started by @gonzaloriestra