Skip to content

[Tests] Cover Result.valueOrAbort and doOnOk error handling - #8346

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-cover-result-value-or-abort-12351794898830924622
Draft

[Tests] Cover Result.valueOrAbort and doOnOk error handling#8346
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-cover-result-value-or-abort-12351794898830924622

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #0000

The valueOrAbort method and the Err branch of doOnOk in packages/cli-kit/src/public/node/result.ts lacked unit test coverage.

WHAT is this pull request doing?

Adds unit tests in packages/cli-kit/src/public/node/result.test.ts to cover:

  • valueOrAbort on ok result returns the value.
  • valueOrAbort on err result with FatalError re-throws the original FatalError.
  • valueOrAbort on err result with standard Error throws an AbortError preserving message and stack.
  • valueOrAbort on err result with non-Error value throws an AbortError with string representation.
  • doOnOk on err result does not invoke the handler and returns Err.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 12351794898830924622 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant