[Tests] Cover Result.valueOrAbort and doOnOk error handling - #8346
[Tests] Cover Result.valueOrAbort and doOnOk error handling#8346gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Fixes #0000
The
valueOrAbortmethod and theErrbranch ofdoOnOkinpackages/cli-kit/src/public/node/result.tslacked unit test coverage.WHAT is this pull request doing?
Adds unit tests in
packages/cli-kit/src/public/node/result.test.tsto cover:valueOrAbortonokresult returns the value.valueOrAbortonerrresult withFatalErrorre-throws the originalFatalError.valueOrAbortonerrresult with standardErrorthrows anAbortErrorpreserving message and stack.valueOrAbortonerrresult with non-Error value throws anAbortErrorwith string representation.doOnOkonerrresult does not invoke the handler and returnsErr.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12351794898830924622 started by @gonzaloriestra