[Performance] Optimize rejectGeneratedStaticAssets filtering - #8373
[Performance] Optimize rejectGeneratedStaticAssets filtering#8373gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Why is this change necessary?
In
packages/theme/src/cli/utilities/asset-checksum.ts,rejectGeneratedStaticAssetsconstructedliquidAssetKeysusing chained.filter(...)and.map(...)array operations. This created two temporary intermediate arrays and traversed the theme checksum array twice.How was it resolved?
Replaced the
.filter(...).map(...)chaining with a singlefor...ofloop that directly inserts matching Liquid asset keys into theSet. This avoids extra array allocations and reduces iteration overhead when processing large theme checksum sets during theme operations (e.g.,theme pullortheme push).How to test your changes?
shopify theme pullorshopify theme pushPR created automatically by Jules for task 8883107987903545011 started by @gonzaloriestra