Repository navigation
Constructor of Shopify\Auth\Scopes can't handle null #290
Description
Issue summary
During Auth Begin, a session is created without any scope / accessToken etc.. set. So these fields are null. In this state if $session->isValid() is called, it results in a TypeError.
Because isValid calls Context::$SCOPES->equals($this->scope).
Here $this->scope is null.
SCOPES->equals calls $scopes = new self($scopes);.
And in the constructor of Scopes
shopify-api-php/src/Auth/Scopes.php
Lines 19 to 27 in d368eef
is_string returns false for null type, but this code assumes that is not string, then must be array and continues. Resulting in array_map call throwing a TypeError because it expects array, but null given.
Expected behavior
What do you think should happen?
No PHP TypeError should happen.
Actual behavior
What actually happens?
TypeError
Details
php > require_once 'vendor/autoload_runtime.php';
php > $s = new \Shopify\Auth\Scopes(null);
PHP Warning: Uncaught TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/******************************/vendor/shopify/shopify-api/src/Auth/Scopes.php:27
Stack trace:
#0 /home/******************************/vendor/shopify/shopify-api/src/Auth/Scopes.php(27): array_map()
#1 php shell code(1): Shopify\Auth\Scopes->__construct()
#2 {main}
thrown in /home/******************************/vendor/shopify/shopify-api/src/Auth/Scopes.php on line 27Steps to reproduce the problem
php -a
require_once 'vendor/autoload_runtime.php';
$s = new \Shopify\Auth\Scopes(null);Reduced test case
The best way to get your bug fixed is to provide a reduced test case.
Checklist
- I have described this issue in a way that is actionable (if possible)
Possible Solution
public function __construct($scopes)
{
if (is_string($scopes)) {
$scopesArray = explode(self::SCOPE_DELIMITER, $scopes);
} else {
$scopesArray = $scopes ?? [];
}Adding ?? [] should fix it.
Or Session->isValid shouldn't call Context::$SCOPES->equals if $this->scope is null.
Activity
github-actions commentedon Sep 24, 2023
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.
github-actions commentedon Nov 26, 2023
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.
github-actions commentedon Dec 10, 2023
We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.
If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines
Thank you!
devhus commentedon Jul 31, 2024
No one fixed this issue yet ??
sarim commentedon Jul 31, 2024
@devhus you can see I opened a pull request #299 way back then. But didn't receive any response.