Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

[Fix] Scopes constructor handle null parameter - #299

Closed
sarim wants to merge 2 commits into
Shopify:mainfrom
sarim:main
Closed

sarim wants to merge 2 commits into
Shopify:mainfrom
sarim:main

Conversation

@sarim

@sarim sarim commented Sep 26, 2023 •

Copy link
Copy Markdown

WHY are these changes introduced?

Fixes #290

WHAT is this pull request doing?

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@sarim
sarim marked this pull request as ready for review September 26, 2023 22:22
@sarim

sarim commented Sep 26, 2023

Copy link
Copy Markdown
Author

I have signed the CLA!

@Suleimanlatrsh

Copy link
Copy Markdown
Contributor

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-php instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constructor of Shopify\Auth\Scopes can't handle null

2 participants