Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Fix the issue "Get Current Session ID process from Post Purchase Extension Token" - #279

Closed
jonaswebdev wants to merge 9 commits into
Shopify:mainfrom
jonaswebdev:main
Closed

jonaswebdev wants to merge 9 commits into
Shopify:mainfrom
jonaswebdev:main

Conversation

@jonaswebdev

@jonaswebdev jonaswebdev commented May 29, 2023 •

Copy link
Copy Markdown

WHY are these changes introduced?

Shopify issues an incomplete token/JWT payload from Checkout::PostPurchase::ShouldRender & Checkout::PostPurchase::Render methods on the Post-Purchase Extension.

The "dest" attribute is missing on the JWT payload and should contain the shop domain, so it throws an exception on the Get Current Session ID on the OAuth Process (Class: Shopify\Auth\OAuth, Method: getCurrentSessionId).

I related more details here.

WHAT is this pull request doing?

Workaround to get the shop domain from "input_data" attribute from JWT.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@jonaswebdev

Copy link
Copy Markdown
Author

I have signed the CLA!

Comment thread composer.json Outdated
Comment thread composer.json Outdated
@jonaswebdev

Copy link
Copy Markdown
Author

Hi @rafaelstz I invited you to my repository to you have "write access", please review, thank you

@rafaelstz

Copy link
Copy Markdown

Hi @jonaswebdev, I'm not part of the Shopify team, so I won't be able to approve it.

shopify-api-php v5.1.0 updates
@Suleimanlatrsh

Copy link
Copy Markdown
Contributor

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-php instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants